-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow --detach and --quiet flags when using --rollback #144
Allow --detach and --quiet flags when using --rollback #144
Conversation
Commit 78c204e added (f9bd8ec in the moby repo) a validation to prevent `--rollback` from being used in combination with other flags that update the service spec. This validation was not taking into account that some flags only affect the CLI behavior, and are okay to be used when rolling back. This patch updates the validation, and adds `--quiet` and `--detach` to the list of allowed flags. Signed-off-by: Sebastiaan van Stijn <[email protected]>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=======================================
Coverage 44.96% 44.96%
=======================================
Files 169 169
Lines 11378 11378
=======================================
Hits 5116 5116
Misses 5970 5970
Partials 292 292 |
Kind of stinks we can't specify the rollback order when rolling back. |
@cpuguy83: For the swarm manager to know it's doing a rollback, the rollback has to happen server-side instead of the client just submitting |
Also related to this; #142
Perhaps a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐸
Commit 78c204e (moby/moby@f9bd8ec / moby/moby#31108 in the moby repo) added a validation to prevent
--rollback
from being used in combination with other flags that update the service spec.This validation was not taking into account that some flags only affect the CLI behavior, and are okay to be used when rolling back.
This patch updates the validation, and adds
--quiet
and--detach
to the list of allowed flags.relates to moby/moby#33444 (comment)