Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using strings.Builder instead of string appending #1423

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

denverdino
Copy link
Contributor

- What I did

Fix #1422

Using strings.Builder instead of string appending in image prune command

- How I did it

- How to verify it

Pass the test case and the manual test

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-io
Copy link

Codecov Report

Merging #1423 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1423      +/-   ##
==========================================
+ Coverage   54.26%   54.27%   +0.01%     
==========================================
  Files         289      289              
  Lines       19331    19337       +6     
==========================================
+ Hits        10490    10496       +6     
  Misses       8165     8165              
  Partials      676      676

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants