[DO NOT MERGE] cli: add OCI to image save/load #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR vendors moby/moby#33355 to build the binary, so don't merge it yet |
Signed-off-by: Antonio Murdaca <[email protected]>
runcom
changed the title
|
@runcom Do you have time to update this with a workflow description? :) |
|
Where do I have to add a workflow description? The commands have been designed/discussed here mostly moby/moby#26369 |
|
@runcom Just to the description of this PR. If they are the same, just copy them over so people don't have to guess. I'll still build this version and give it a try in bit. |
|
@thaJeztah The other PR needs to be rebased but we haven't heard back from @runcom. I am wondering if we are going to have to carry these PRs. |
|
I have fixed, rebased and added tests on the Moby side. I'd love to have that merged first before diving into docker itself. I'll rebase this as I get a chance though. |
vdemeester
added
status/2-code-review
status/needs-vendoring
and removed
status/0-triage
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client side stuff split from moby/moby#26369
/cc @stevvooe @thaJeztah @cpuguy83 @vbatts
server side is moby/moby#33355
Signed-off-by: Antonio Murdaca [email protected]