-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for --health-start-period in Compose/Stack file #116
Comments
Should this be against the docker/compose project as opposed to the docker/cli? |
@electrofelix Don't know, @thaJeztah pointed me to this repo. My request is that this config should be implemented in Stack and should be gracefully ignored in Compose |
Having see this appear in CE, I was going to open a request in the compose project for it to be supported when I stumbled across this issue. Noticed that the code in this repo already supports a |
Is there an issue in compose project? |
ping @shin- do you know? ^^ |
docker/compose#4646 is the closest we've had, but now that the feature's in engine we can open a new ticket. |
@thaJeztah and what about Stack, which is where the issue is more relevant? Right now I have to deploy a stack with a yaml file and then issue a |
Seems it’s not yet supported docker/cli#116 but also don’t really need it with the 5min interval.
|
@vdemeester Since you are the assignee, can you tell us if/when this is going to be implemented? Thanks :) |
@vide ohh dang it I forgot about that one… 🤔 I'll try to work on sthg during August 👼 (so I'm hoping to get it in 17.08 or at least in 17.09 (stable) |
Still targeted for 17.08? |
Submit the PR #475 |
@denverdino thanks for the PR! I'll update my preprod cluster to 17.09 ASAP and try it out |
as commented in the pull request: tried with |
It was added to v3.4 of the compose file, what version do you have in the file? |
just updated to v3.4 . Looks good! Thanks! |
Here is the corresponding pull docker/compose#5101 |
…-master-774d78fcb84053f7648fae2358d7657feeb6b03b [master] sync to upstream master 774d78f
Description
With Docker CE 17.05 there is the brand new
--health-start-period
option for a service, implemented with moby/moby#28938. But there is no such option available in a Compose/Stack file, so we can properly manage it with a YAML file.I think I'm not qualified to propose the key name that should eventually implemented in theCompose file but I'd say that
start_period
, underhealthcheck
could be a good name.The text was updated successfully, but these errors were encountered: