templates: linting: fix "error return value is not checked (errchkjson)

The linter is correct; given that these functions do not allow for an error to be returned, we panic. Alternatively, we could return the error string as output, or add a `//nolint:errchkjson` comment. templates/templates.go:17:3: Error return value of `(*encoding/json.Encoder).Encode` is not checked: unsafe type `interface{}` found (errchkjson) enc.Encode(v) ^ Signed-off-by: Sebastiaan van Stijn <[email protected]>
docker · Nov 20, 2023 · 30d36e9 · 30d36e9
1 parent 4e2477f
commit 30d36e9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.golangci.yml b/.golangci.yml
@@ -5,6 +5,7 @@ linters:
     - dogsled
     - dupword       # Detects duplicate words.
     - durationcheck
+    - errchkjson
     - exportloopref # Detects pointers to enclosing loop variables.
     - gocritic      # Metalinter; detects bugs, performance, and styling issues.
     - gocyclo

diff --git a/templates/templates.go b/templates/templates.go
@@ -14,7 +14,11 @@ var basicFunctions = template.FuncMap{
 		buf := &bytes.Buffer{}
 		enc := json.NewEncoder(buf)
 		enc.SetEscapeHTML(false)
-		enc.Encode(v)
+		err := enc.Encode(v)
+		if err != nil {
+			panic(err)
+		}
+
 		// Remove the trailing new line added by the encoder
 		return strings.TrimSpace(buf.String())
 	},