Change to enable volume name can be customized.

Signed-off-by: Liping Xue <[email protected]>
Change to enable volume name can be customized.
Signed-off-by: Liping Xue <[email protected]>

Change to enable volume name can be customized.

Remove unused debug info.

Address comments from Daniel and solve the lint error.
Signed-off-by: Liping Xue <[email protected]>

Address Daniel's comments to print warning message when name of external volume is set in loader code.
Signed-off-by: Liping Xue <[email protected]>

Address Daniel's comments to return error when external volume is set in loader code.
Signed-off-by: Liping Xue <[email protected]>

Address Daniel's comments to return error when external volume is set in loader code.
Signed-off-by: Liping Xue <[email protected]>

Remove the case that specifying external volume name in full-example.yml.

More fix.

Add unit test.
Signed-off-by: Liping Xue <[email protected]>

Address comments from Daniel, move the schema change to v3.4.
Signed-off-by: Liping Xue <[email protected]>

Address comments from Sebastiaan. Signed-off-by: Liping Xue <[email protected]>

Address comments from Misty.
Signed-off-by: Liping Xue <[email protected]>

cli/compose/convert/volume.go

@@ -74,6 +74,10 @@ func convertVolumeToMount(
 		return result, nil
 	}
 
+	if stackVolume.Name != "" {
+		result.Source = stackVolume.Name
+	}
+
 	result.VolumeOptions.Labels = AddStackLabel(namespace, stackVolume.Labels)
 	if stackVolume.Driver != "" || stackVolume.DriverOpts != nil {
 		result.VolumeOptions.DriverConfig = &mount.Driver{

cli/compose/convert/volume_test.go

@@ -98,6 +98,53 @@ func TestConvertVolumeToMountNamedVolume(t *testing.T) {
 	assert.Equal(t, expected, mount)
 }
 
+func TestConvertVolumeToMountNamedVolumeWithNameCustomizd(t *testing.T) {
+	stackVolumes := volumes{
+		"normal": composetypes.VolumeConfig{
+			Name:   "user_specified_name",
+			Driver: "vsphere",
+			DriverOpts: map[string]string{
+				"opt": "value",
+			},
+			Labels: map[string]string{
+				"something": "labeled",
+			},
+		},
+	}
+	namespace := NewNamespace("foo")
+	expected := mount.Mount{
+		Type:     mount.TypeVolume,
+		Source:   "user_specified_name",
+		Target:   "/foo",
+		ReadOnly: true,
+		VolumeOptions: &mount.VolumeOptions{
+			Labels: map[string]string{
+				LabelNamespace: "foo",
+				"something":    "labeled",
+			},
+			DriverConfig: &mount.Driver{
+				Name: "vsphere",
+				Options: map[string]string{
+					"opt": "value",
+				},
+			},
+			NoCopy: true,
+		},
+	}
+	config := composetypes.ServiceVolumeConfig{
+		Type:     "volume",
+		Source:   "normal",
+		Target:   "/foo",
+		ReadOnly: true,
+		Volume: &composetypes.ServiceVolumeVolume{
+			NoCopy: true,
+		},
+	}
+	mount, err := convertVolumeToMount(config, stackVolumes, namespace)
+	assert.NoError(t, err)
+	assert.Equal(t, expected, mount)
+}
+
 func TestConvertVolumeToMountNamedVolumeExternal(t *testing.T) {
 	stackVolumes := volumes{
 		"outside": composetypes.VolumeConfig{

cli/compose/loader/full-example.yml

@@ -1,4 +1,4 @@
-version: "3.3"
+version: "3.4"
 
 services:
   foo:
@@ -280,6 +280,15 @@ volumes:
       foo: "bar"
       baz: 1
 
+  another-volume:
+    name: "user_specified_name"
+    driver: vsphere
+
+    driver_opts:
+      # Values can be strings or numbers
+      foo: "bar"
+      baz: 1
+
   external-volume:
     # Specifies that a pre-existing volume called "external-volume"
     # can be referred to within this file as "external-volume"
@@ -288,5 +297,12 @@ volumes:
   other-external-volume:
     # Specifies that a pre-existing volume called "my-cool-volume"
     # can be referred to within this file as "other-external-volume"
+    # This example uses the deprecated "volume.external.name" (replaced by "volume.name")
     external:
       name: my-cool-volume
+
+  external-volume3:
+    # Specifies that a pre-existing volume called "this-is-volume3"
+    # can be referred to within this file as "external-volume3"
+    name: this-is-volume3
+    external: true

cli/compose/loader/loader.go

@@ -444,6 +444,12 @@ func LoadVolumes(source map[string]interface{}) (map[string]types.VolumeConfig,
 			if volume.External.Name == "" {
 				volume.External.Name = name
 				volumes[name] = volume
+			} else {
+				logrus.Warnf("volume %s: volume.external.name is deprecated in favor of volume.name", name)
+
+				if volume.Name != "" {
+					return nil, errors.Errorf("volume %s: volume.external.name and volume.name conflict; only use volume.name", name)
+				}
 			}
 		}
 	}

cli/compose/loader/loader_test.go

@@ -628,6 +628,22 @@ volumes:
 	assert.Contains(t, err.Error(), "external_volume")
 }
 
+func TestInvalidExternalNameAndNameCombination(t *testing.T) {
+	_, err := loadYAML(`
+version: "3.4"
+volumes:
+  external_volume:
+    name: user_specified_name
+    external:
+      name:	external_name
+`)
+
+	assert.Error(t, err)
+	fmt.Println(err)
+	assert.Contains(t, err.Error(), "volume.external.name and volume.name conflict; only use volume.name")
+	assert.Contains(t, err.Error(), "external_volume")
+}
+
 func durationPtr(value time.Duration) *time.Duration {
 	return &value
 }
@@ -983,6 +999,14 @@ func TestFullExample(t *testing.T) {
 				"baz": "1",
 			},
 		},
+		"another-volume": {
+			Name:   "user_specified_name",
+			Driver: "vsphere",
+			DriverOpts: map[string]string{
+				"foo": "bar",
+				"baz": "1",
+			},
+		},
 		"external-volume": {
 			External: types.External{
 				Name:     "external-volume",
@@ -995,6 +1019,13 @@ func TestFullExample(t *testing.T) {
 				External: true,
 			},
 		},
+		"external-volume3": {
+			Name: "this-is-volume3",
+			External: types.External{
+				Name:     "external-volume3",
+				External: true,
+			},
+		},
 	}
 
 	assert.Equal(t, expectedVolumeConfig, config.Volumes)

cli/compose/schema/data/config_schema_v3.4.json

@@ -437,6 +437,7 @@
       "id": "#/definitions/volume",
       "type": ["object", "null"],
       "properties": {
+        "name": {"type": "string"},
         "driver": {"type": "string"},
         "driver_opts": {
           "type": "object",