Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-container: set UsernsMode only when needed #887

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

AkihiroSuda
Copy link
Collaborator

@AkihiroSuda AkihiroSuda commented Dec 15, 2021

Set UsernsMode="host" only when the daemon is running in userns-remapping mode.

Fix #561

The issue will be also fixed in moby/moby#43084 (Docker 20.10.13).
This buildx PR helps users of old releases of Docker.

Set `UsernsMode="host"` only when the daemon is running in userns-remapping mode.

Fix issue 561

The issue will be also fixed in moby/moby PR 43084 (Docker 20.10.13).
This buildx PR helps users of old releases of Docker.

Signed-off-by: Akihiro Suda <[email protected]>
@aarongable
Copy link

I locally rebuilt the buildx plugin with this commit applied and confirmed that this resolves the issue for me.

@jedevc
Copy link
Collaborator

jedevc commented Oct 20, 2022

@AkihiroSuda could we move this logic into the driver instead of having it in the factory, so that we check the property when creating the container? I'm happy to do it, just wanted to check if there was a reason it was done this way?

With #1206, if the Docker socket isn't available then the factory will fail, so we can't create new docker-container builders as in #1358 (ideally, this would only fail if we passed --bootstrap as well).

@AkihiroSuda
Copy link
Collaborator Author

@jedevc SGTM 👌

@jedevc jedevc mentioned this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants