docker-container: set UsernsMode only when needed #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set `UsernsMode="host"` only when the daemon is running in userns-remapping mode. Fix issue 561 The issue will be also fixed in moby/moby PR 43084 (Docker 20.10.13). This buildx PR helps users of old releases of Docker. Signed-off-by: Akihiro Suda <[email protected]>
|
I locally rebuilt the buildx plugin with this commit applied and confirmed that this resolves the issue for me. |
tonistiigi
approved these changes
Dec 16, 2021
|
@AkihiroSuda could we move this logic into the driver instead of having it in the factory, so that we check the property when creating the container? I'm happy to do it, just wanted to check if there was a reason it was done this way? With #1206, if the Docker socket isn't available then the factory will fail, so we can't create new docker-container builders as in #1358 (ideally, this would only fail if we passed |
|
@jedevc SGTM 👌 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
UsernsMode="host"only when the daemon is running in userns-remapping mode.Fix #561
The issue will be also fixed in moby/moby#43084 (Docker 20.10.13).
This buildx PR helps users of old releases of Docker.