Add NetworkMode to bake target

[zachary-povey]

Allows specification of network mode in a bake target.

Fixes #848

Signed-off-by: Zachary Povey [email protected]

[tonistiigi]

I wonder if we should leave it only for compose files for now. Using build --network is discouraged in buildx. Instead you are supposed to use RUN --network inside the dockerfile https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/syntax.md#network-modes-run---networknonehostdefault and allow network entitlement on build. Proposal for entitlements support in bake is in #179

[zachary-povey]

@tonistiigi - happy to change it to just compose files, should I do that?

My use case for this is backwards compatibility with docker-compose anyway, it just seemed (from a naive perspective) if something was available to build it should be available via a bake target.

[tonistiigi]

happy to change it to just compose files, should I do that?

I think so. cc @crazy-max

[crazy-max]

happy to change it to just compose files, should I do that?

I think so. cc @crazy-max

Yes sgtm

[zachary-povey]

Ok, thanks both :)

@tonistiigi I've pushed a commit removing support from HCL/JSON files. Did you also want me to remove the ability to specify it via a cmd line override with --set?

[crazy-max]

Did you also want me to remove the ability to specify it via a cmd line override with --set?

Yes remove the override for this case.

[zachary-povey]

Ok that's done now 👍

[zachary-povey]

@tonistiigi @crazy-max - think this is good to go now?

[crazy-max]

LGTM