Allow users to have separate store paths #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
commented
Sep 8, 2020
|
Two UX questions:
|
errordeveloper
force-pushed
the
fix-308
branch
2 times, most recently
from
cbf1b82 to
947664b
Compare
|
I'm ok with the I think loading a builder config from a file or having project-specific builders is a valid use case but probably these should be handled separately. |
|
@tonistiigi thanks for the review, and I think you are right. I will revisit this ping you once it is ready for review. |
errordeveloper
force-pushed
the
fix-308
branch
from
947664b to
394bb50
Compare
|
@tonistiigi please have another look now! |
tonistiigi
reviewed
Sep 10, 2020
commands/util.go
Outdated
| // of Docker config file (i.e. `${DOCKER_CONFIG}/buildx`) | ||
| func getConfigStorePath(dockerCli command.Cli) string { | ||
| if buildxConfig := os.Getenv("BUILDX_CONFIG"); buildxConfig != "" { | ||
| logrus.Infof("using config store %q based in \"$BUILDX_CONFIG\" environment variable", buildxConfig) |
There was a problem hiding this comment.
could you change these to Debugf
- decouple store path from `$DOCKER_CONFIG` - improve containerised build setup - introduce new `$BUILDX_CONFIG` environment variable Signed-off-by: Ilya Dmitrichenko <[email protected]>
errordeveloper
force-pushed
the
fix-308
branch
from
394bb50 to
4b2aab0
Compare
tonistiigi
approved these changes
Sep 10, 2020
|
Thanks!
…On Thu, 10 Sep 2020, 6:24 pm Tõnis Tiigi, ***@***.***> wrote:
Merged #385 <#385> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#385 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5MSY654AH42QZFJWDTR3SFEDUNANCNFSM4Q7XMVDA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$DOCKER_CONFIG$BUILDX_CONFIGenvironment variableRelated to #308