Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use k8s cluster config when buildx used in k8s cluster #368

Merged
merged 1 commit into from
Aug 29, 2020
Merged

feat: use k8s cluster config when buildx used in k8s cluster #368

merged 1 commit into from
Aug 29, 2020

Conversation

morlay
Copy link
Collaborator

@morlay morlay commented Aug 28, 2020

grant permission to service account of pod.

@tonistiigi tonistiigi requested a review from AkihiroSuda August 28, 2020 03:52
AkihiroSuda
AkihiroSuda reviewed Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,thanks, but please sign with full real name?

AkihiroSuda
AkihiroSuda reviewed Aug 28, 2020
View reviewed changes
driver/manager.go Outdated Show resolved Hide resolved
AkihiroSuda
AkihiroSuda requested changes Aug 28, 2020
View reviewed changes
driver/manager.go Outdated Show resolved Hide resolved
@tonistiigi tonistiigi merged commit ee34eb2 into docker:master Aug 29, 2020
@morlay morlay mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morlay @AkihiroSuda @tonistiigi