docker-container: show logs on bootstrap error

[tonistiigi]

fix #331

Second commit also increases daemon start timeout. Previous value was only 2.2sec so could be that this is what triggered #331 initially.

cc @howardjohn

@AkihiroSuda Would be good to get something similar to the kubernetes driver as well.

[pkpfr]

This increases to 14.4 seconds, but it is still inadequate. Running build inside a container inside dockerized Jenkins this timeout frequently gets hit.

[tonistiigi]

@pkpfr Should be plenty to just start a process. This doesn't include pull time or even container start time.

[pkpfr]

@tonistiigi That doesn't equate with my experience.

This is a recent failure:

10:59:28  #1 [internal] booting buildkit
10:59:28  #1 pulling image moby/buildkit:buildx-stable-1
10:59:29  #1 pulling image moby/buildkit:buildx-stable-1 4.7s done
10:59:29  #1 creating container buildx_buildkit_build
10:59:41  #1 creating container buildx_buildkit_build 10.9s done
10:59:41  #1 ERROR: exit code 1

And 2 passes:

11:02:44  #1 [internal] booting buildkit
11:02:44  #1 pulling image moby/buildkit:buildx-stable-1
11:02:44  #1 pulling image moby/buildkit:buildx-stable-1 3.6s done
11:02:44  #1 creating container buildx_buildkit_build
11:02:52  #1 creating container buildx_buildkit_build 8.9s done
11:02:52  #1 DONE 12.5s

11:40:17  #1 [internal] booting buildkit
11:40:17  #1 pulling image moby/buildkit:buildx-stable-1
11:40:21  #1 pulling image moby/buildkit:buildx-stable-1 3.6s done
11:40:21  #1 creating container buildx_buildkit_build
11:40:33  #1 creating container buildx_buildkit_build 10.7s done
11:40:33  #1 DONE 14.2s

[tonistiigi]

Like I said, wait does not equal container create time, just from process starting until it starts to listen on a socket. Furthermore, wait itself calls docker exec 15 times, so if the system would be just under a heavy load these commands would be slow as well, increasing the wait time.

[tonistiigi]

If you get ERROR: exit code 1 with no logs this should indicate that you either don't have this patch or the error is coming from somewhere else and not a wait timeout.