Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bake: ensure --builder is wired from root options #321

Merged
merged 1 commit into from
Jul 19, 2020

Conversation

errordeveloper
Copy link
Contributor

Fix #320

@tonistiigi
Copy link
Member

cc @cpuguy83

Copy link
Contributor

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I missed this.

LGTM

@cpuguy83
Copy link
Contributor

cpuguy83 commented Jul 8, 2020

Before change:

$ docker buildx --builder=foo bake
[+] Building 0.5s (5/9)
[+] Building 0.7s (9/13)

After change:

 $ ./buildx --builder=foo bake
Error: open /Users/cpuguy83/.docker/buildx/instances/foo: no such file or directory
Usage:
  ./buildx bake [OPTIONS] [TARGET...] [flags]

Aliases:
  bake, f

Flags:
  -f, --file stringArray   Build definition file
  -h, --help               help for bake
      --load               Shorthand for --set=*.output=type=docker
      --no-cache           Do not use cache when building the image
      --print              Print the options without building
      --progress string    Set type of progress output (auto, plain, tty). Use plain to show container output (default "auto")
      --pull               Always attempt to pull a newer version of the image
      --push               Shorthand for --set=*.output=type=registry
      --set stringArray    Override target value (eg: targetpattern.key=value)

Global Flags:
      --builder string   Override the configured builder instance

@errordeveloper
Copy link
Contributor Author

errordeveloper commented Jul 8, 2020 via email

@tonistiigi tonistiigi merged commit d8ca460 into docker:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bake --builder is not working
3 participants