-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parsing json config with hcl v2 #280
Conversation
0fbf5b6
to
e5f353c
Compare
Maybe just fallback on error instead of checking the suffix? |
@vanstee Also, could you add a test for this? |
That could work, but I'm worried we'll be losing out on good error info depending on the default and fallback ordering. For instance, it would be confusing to get errors for parsing an hcl config when you missed a comma in a json config. Let me know what you think; the fallback would be pretty easy to implement. |
@vanstee I guess if the file has |
Nice I like it. Will do. |
Signed-off-by: Patrick Van Stee <[email protected]>
Signed-off-by: Patrick Van Stee <[email protected]>
Signed-off-by: Patrick Van Stee <[email protected]>
Signed-off-by: Patrick Van Stee <[email protected]>
Hi! |
Providing a
docker-bake.json
todocker buildx bake
fails to parse because we were always assuminghcl
formatted config after the hcl v2 upgrade.Fixed this by using the json parser based on the file suffix.
Also fixes json keys for groups and targets.
Fixes #278