bake: improve error when using incorrect format for setting labels #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Nov 4, 2024
jsternberg
force-pushed
the
improve-missing-name-set-error
branch
from
e7dcf1f to
55c2ea9
Compare
|
Done. Updated the message. I think that likely communicates more explicitly. |
tonistiigi
reviewed
Nov 4, 2024
bake/bake.go
Outdated
| @@ -865,23 +867,23 @@ func (t *Target) AddOverrides(overrides map[string]Override) error { | |||
| t.Dockerfile = &value | |||
| case "args": | |||
| if len(keys) != 2 { | |||
| return errors.Errorf("args require name") | |||
| return errors.Errorf("invalid format for args, expecting args.${name}") | |||
Improves the error message when using an incorrect format for setting labels. This includes the intended format directly in the error message instead of assuming the user knows what the format is. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
improve-missing-name-set-error
branch
from
55c2ea9 to
a5bb117
Compare
tonistiigi
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the error message when using an incorrect format for setting labels. This includes the intended format directly in the error message instead of assuming the user knows what the format is.
Fixes #2315.