Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align file and folder permissions #2739

Closed
wants to merge 1 commit into from

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 16, 2024

When invoking docker with sudo the owner will not be the one from user space and therefore some files and folders in buildx config might not be accessible by other tools (on macos sudo keeps user home dir). This affects reading current builder, last activity for a builder or local state. This change aligns file and folder permissions. Similar to how image id and metadata file are currently created:

And same with cli when creating context: https://github.com/docker/cli/blob/31eeed7ca4c951ede2d18c73e4bd47e8189be221/cli/context/store/metadatastore.go#L43

This will avoid permissions issues reported on Docker Desktop when opening the build view on macos.

@crazy-max crazy-max added this to the v0.18.0 milestone Oct 16, 2024
@crazy-max crazy-max marked this pull request as ready for review October 16, 2024 13:26
@crazy-max crazy-max removed this from the v0.18.0 milestone Oct 18, 2024
@crazy-max crazy-max marked this pull request as draft October 18, 2024 11:40
@crazy-max crazy-max deleted the align-perms branch October 25, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment