Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ls: ensure deterministic output for truncated platforms #2717

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

crazy-max
Copy link
Member

relates to https://github.com/docker/buildx/actions/runs/11169979364/job/31051857680#step:6:1094

=== FAIL: commands TestTruncPlatforms/all_preferred (0.00s)
    ls_test.go:171: 
        	Error Trace:	/home/runner/work/buildx/buildx/commands/ls_test.go:171
        	Error:      	Not equal: 
        	            	expected: "linux/arm64*, linux/arm* (+3), darwin/arm64*, windows/arm64*"
        	            	actual  : "linux/arm64*, linux/arm* (+3), windows/arm64*, darwin/arm64*"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-linux/arm64*, linux/arm* (+3), darwin/arm64*, windows/arm64*
        	            	+linux/arm64*, linux/arm* (+3), windows/arm64*, darwin/arm64*
        	Test:       	TestTruncPlatforms/all_preferred
    --- FAIL: TestTruncPlatforms/all_preferred (0.00s)

=== FAIL: commands TestTruncPlatforms (0.00s)

@tonistiigi tonistiigi merged commit d353f5f into docker:master Oct 4, 2024
106 checks passed
@crazy-max crazy-max deleted the fix-ls-notrunc branch October 4, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants