-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bake: support compose ssh config #2445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi @ndeloof
Looking at the failed check: sorting for multiple ssh keys does not appear to be stable. Do we want bake to make it stable or should we just change to an |
@sumnerwarren Is it already coming unsorted from compose? In that case, it should be fixed in there. Meanwhile, we can just add some forced sorting in here to get this merged. |
@tonistiigi Yes, it's coming from compose unsorted, at least on macos. I ran
I just pushed a commit that includes sorting. Note: I'm not a go expert, but I think it stems from using range on a map, which does not have a defined sort order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Don't think we need a separate commit for sorting, can you squash commits please? Otherwise LGTM
Signed-off-by: Sumner Warren <[email protected]>
9fad805
to
224c6a5
Compare
Adds support for compose ssh config with bake. See spec. Based on #1069. This does not remove support for the
x-bake
ssh
field.