controller: only capture the result when invoked through a controller #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the code used to capture and evaluated a result is only executed when built through the controller. Otherwise, no build result should be recorded. This ensures that new code added to capture and store the build result for debugging isn't used when BUILDX_EXPERIMENTAL is not set. Signed-off-by: Justin Chadwell <[email protected]>
tonistiigi
approved these changes
Apr 18, 2023
| resp, err = build.BuildWithResultHandler(ctx, nodes, opts, dockerutil.NewClient(dockerCli), confutil.ConfigDir(dockerCli), progress.Tee(printer, statusChan), func(driverIndex int, gotRes *build.ResultContext) { | ||
| mu.Lock() | ||
| defer mu.Unlock() | ||
| if res == nil || driverIndex < idx { |
There was a problem hiding this comment.
This logic here does not make sense to me. But it is in old code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the code used to capture and evaluated a result is only executed when built through the controller. Otherwise, no build result should be recorded.
This ensures that new code added to capture and store the build result for debugging isn't used when BUILDX_EXPERIMENTAL is not set.
See #1640 (comment) for more information.
This should be removed at some point in the future - however, for now, we should have something like this to prevent breaking the state of master while we work on the debugging functionality.