Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: fix docker context not validated #1596

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 3, 2023

Fixes a regression introduced by #1439 (8c47277) (probably bad rebase 😞) where DockerContext is not being set anymore and therefore validation is always skipped in:

if b.NodeGroup.DockerContext {

Signed-off-by: CrazyMax [email protected]

@crazy-max crazy-max merged commit a328813 into docker:master Feb 6, 2023
@crazy-max crazy-max deleted the builder-fix-validation branch February 6, 2023 11:31
Copy link

@goinst-hub goinst-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@thaJeztah
Copy link
Member

^^ I blocked the account, and reported to GitHub support for abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants