Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting tidy-ups #1582

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Linting tidy-ups #1582

merged 3 commits into from
Feb 1, 2023

Conversation

jedevc
Copy link
Collaborator

@jedevc jedevc commented Feb 1, 2023

Adds two new linting rules, gosec (to catch potential security issues, similar to moby/buildkit#3224), and forbidigo (to catch use of fmt.Errorf, similar to moby/buildkit#3305).

The gosec fixups did catch a couple of loop reference issues in the bake code, where we continued looping after capturing a reference from the loop - which would invalidate that reference. @crazy-max can you confirm these look alright to you now?

Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedevc jedevc merged commit d2fa4a5 into docker:master Feb 1, 2023
@jedevc jedevc deleted the lint-fixups branch February 1, 2023 16:08
@crazy-max crazy-max added this to the v0.10.3 milestone Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants