build: fix env vars check for vcs details #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]>
jedevc
approved these changes
Dec 14, 2022
tianon
reviewed
Dec 15, 2022
| setGitLabels = v | ||
| } | ||
| } | ||
| setGitInfo := true | ||
| if v, ok := os.LookupEnv("BUILDX_GIT_INFO"); ok { | ||
| if v, _ := strconv.ParseBool(v); v { | ||
| if v, err := strconv.ParseBool(v); err == nil { |
There was a problem hiding this comment.
If these variables are set but to an invalid value, shouldn't that error bubble up too? 😅
(strconv.ParseBool is very generous in the number of values it accepts already 😄)
There was a problem hiding this comment.
I was not sure as we want to fail silently but makes sense as this is a user input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: CrazyMax [email protected]