Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't set add-hosts option if empty #1457

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

jedevc
Copy link
Collaborator

@jedevc jedevc commented Dec 7, 2022

This looks like an oversight, all of the other options have similar checks. This can interfere with generated provenance where "add-hosts" will be marked as an argument to the build, even though it's not actually being utilized.

This looks like an oversight, all of the other options have similar
checks. This can interfere with generated provenance where "add-hosts"
will be marked as an argument to the build, even though it's not
actually being utilized.

Signed-off-by: Justin Chadwell <[email protected]>
@tonistiigi tonistiigi merged commit abc8121 into docker:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants