Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progress: explicitly fail if tty requested but not available #1371

Merged
merged 1 commit into from
Oct 25, 2022
Merged

progress: explicitly fail if tty requested but not available #1371

merged 1 commit into from
Oct 25, 2022

Commits on Oct 25, 2022

  1. progress: explicitly fail if tty requested but not available 

    The NewPrinter function is mostly borrowed from buildkit. However, at
some point, it seems that the implementations drifted.

This patch updates buildx to be more similar in behavior to it's
buildkit counterpart, specifically, it will explicitly fail if a TTY
output is requested using "--progress=tty", but the output is not
available.

To gracefully fallback to plain progress in this scenario,
"--progress=plain" is required.

Signed-off-by: Justin Chadwell <[email protected]>
    @jedevc
    jedevc committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    a50e89c View commit details
    Browse the repository at this point in the history