-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote driver guide #1093
Add remote driver guide #1093
Conversation
f48c062
to
55397f4
Compare
@crazy-max have updated to follow the guide to follow the new-style docs (and tested to make sure they'll look alright on docs.docker.com, once docker/docs#14644 is merged). |
d14eda7
to
e57a6b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ptal @tonistiigi @thaJeztah
|
||
```console | ||
$ sudo ./buildkitd --group $(id -gn) --addr unix://$HOME/buildkitd.sock | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d rather recommend using rootless mode, but that can be another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep it simple as it is and add a link to https://github.com/moby/buildkit/blob/master/docs/rootless.md for rootless. Could even leave the default socket path. Can also point to https://github.com/moby/buildkit/tree/master/examples/systemd for running buildkitd with systemd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have setup those links right below this to point users in the right direction - I think we should keep the specified socket path, otherwise we'll also need to tell users later on to use sudo buildx (since the /var/run/buildkit/
directory is owned by root:root
and inaccessible, even with --group
, though maybe that's a bug?).
|
||
```console | ||
$ sudo ./buildkitd --group $(id -gn) --addr unix://$HOME/buildkitd.sock | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep it simple as it is and add a link to https://github.com/moby/buildkit/blob/master/docs/rootless.md for rootless. Could even leave the default socket path. Can also point to https://github.com/moby/buildkit/tree/master/examples/systemd for running buildkitd with systemd.
61b72ba
to
a2f1de6
Compare
Signed-off-by: Justin Chadwell <[email protected]>
Added basic scenarios for: