-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildkitd.default.toml is not taken into account #2683
Comments
It seems good on my side:
In the container I have the conf:
And buildkitd is using it:
You are seeing Lines 670 to 672 in 40f444f
Looking at this I think we should display buildkitd config file content when using |
@crazy-max I updated the configuration section. You're right that the buildkitd flag shows network.host entitlement only since it doesn't display the buildkitd config. However I'm still seeing issues with security.insecure when set using buildkitd.default.toml, even though it's showing in the container
|
Yes this might be a bug with entitlements as setting |
yes, you're right, |
Ok looking at buildkit code we are overriding whatever is set in configuration if a flag is set: https://github.com/moby/buildkit/blob/3a7055008a5e58a2abbe0e0c21c919d9e014e062/cmd/buildkitd/main.go#L583-L584 I think we should merge in this case otherwise it would never take into account insecure entitlements from config as we are always setting I'm afraid this is "broken" since Buildx v0.13.0 😨 |
Or we could check if |
closing this one as this is working as intended but will open a PR related to #2683 (comment) |
Contributing guidelines
I've found a bug and checked that ...
Description
By default, buildx should use a default buildkitd config if it exists in any of the following locations:
But it does not seem like buildx is interpreting this config at all.
Expected behaviour
Settings in e.g.
~/.docker/buildx/buildkitd.default.toml
should be automatically picked up withbuildx create
Actual behaviour
buildkitd.default.toml
is ignoredBuildx version
github.com/docker/buildx v0.17.0 78c8c28
Docker info
No response
Builders list
Configuration
Build logs
No response
Additional info
No response
The text was updated successfully, but these errors were encountered: