Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Environment variables in docker-container driver #169

Closed
sirlatrom opened this issue Oct 23, 2019 · 0 comments · Fixed by #170
Closed

Feature request: Environment variables in docker-container driver #169

sirlatrom opened this issue Oct 23, 2019 · 0 comments · Fixed by #170

Comments

@sirlatrom
Copy link
Contributor

The docker-container driver currently provides no way to specify environment variables such as HTTP_PROXY and HTTPS_PROXY, making it impossible to use it behind a proxy.
sirlatrom added a commit to sirlatrom/buildx that referenced this issue Oct 23, 2019
@sirlatrom
Support environment variables in docker-container driver
4af657c 
Fixes docker#169

Signed-off-by: Sune Keller <[email protected]>
@sirlatrom sirlatrom mentioned this issue Oct 23, 2019
Merged
sirlatrom added a commit to sirlatrom/buildx that referenced this issue Oct 26, 2019
@sirlatrom
Support environment variables in docker-container driver
d8df6ee 
Fixes docker#169

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/buildx that referenced this issue Oct 28, 2019
@sirlatrom
Support environment variables in docker-container driver
c4d3301 
Fixes docker#169

Signed-off-by: Sune Keller <[email protected]>
sirlatrom pushed a commit to sirlatrom/buildx that referenced this issue Oct 28, 2019
@daixiang0 @sirlatrom
Support environment variables in docker-container driver
d9ca31d 
Fixes docker#169

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/buildx that referenced this issue Oct 28, 2019
@sirlatrom
Support environment variables in docker-container driver
0abfd0e 
Fixes docker#169

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/buildx that referenced this issue Oct 28, 2019
@sirlatrom
Support environment variables in docker-container driver
fd44acc 
Fixes docker#169

Signed-off-by: Sune Keller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support environment variables in docker-container driver sirlatrom/buildx
1 participant
@sirlatrom