compose: load env from service environment

Signed-off-by: CrazyMax <[email protected]>
docker · Jan 6, 2022 · 2a995b9 · 2a995b9
1 parent 3400fa5
commit 2a995b9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/bake/compose.go b/bake/compose.go
@@ -76,6 +76,9 @@ func ParseCompose(dt []byte) (*Config, error) {
 				Dockerfile: dockerfilePathP,
 				Labels:     s.Build.Labels,
 				Args: flatten(s.Build.Args.Resolve(func(val string) (string, bool) {
+					if val, ok := s.Environment[val]; ok && val != nil {
+						return *val, true
+					}
 					val, ok := cfg.Environment[val]
 					return val, ok
 				})),

diff --git a/bake/compose_test.go b/bake/compose_test.go
@@ -293,12 +293,21 @@ services:
   scratch:
     build:
      context: .
+     args:
+        CT_ECR: foo
+        FOO:
+        NODE_ENV:
+    environment:
+      - NODE_ENV=test
+      - AWS_ACCESS_KEY_ID=dummy
+      - AWS_SECRET_ACCESS_KEY=dummy
     env_file:
       - ` + envf.Name() + `
 `)
 
-	_, err = ParseCompose(dt)
+	c, err := ParseCompose(dt)
 	require.NoError(t, err)
+	require.Equal(t, c.Targets[0].Args, map[string]string{"CT_ECR": "foo", "FOO": "bsdf -csdf", "NODE_ENV": "test"})
 }
 
 func newBool(val bool) *bool {