Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extra scanners to be configured #117

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Allow extra scanners to be configured #117

merged 3 commits into from
Dec 10, 2024

Conversation

cdupuis
Copy link
Collaborator

@cdupuis cdupuis commented Dec 10, 2024

fixes #109

@cdupuis cdupuis requested a review from crazy-max December 10, 2024 12:45
@crazy-max
Copy link
Member

https://github.com/docker/buildkit-syft-scanner/actions/runs/12257150367/job/34194000758?pr=117#step:7:106

[-] Checking example npm-lock...
  [-] Checking schema ./examples/npm-lock/checks/sbom-base.spdx.json...
slice mismatch on .predicate.packages[1], expected [map[SPDXID:=package name:lodash] map[SPDXID:=package name:npm]]

Forgot to rebuild the local image when testing locally 🤦‍♂️ so it doesn't handle extra catalogs.

@crazy-max crazy-max force-pushed the issue-109 branch 3 times, most recently from 125506b to b47ad8d Compare December 10, 2024 13:46
@crazy-max
example: fix npm-lock
1adc966 
Signed-off-by: CrazyMax <[email protected]>
crazy-max
crazy-max approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdupuis cdupuis requested a review from crazy-max December 10, 2024 13:52
@cdupuis cdupuis merged commit 6139613 into master Dec 10, 2024
11 checks passed
@crazy-max crazy-max deleted the issue-109 branch December 10, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max Awaiting requested review from crazy-max

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Option to Specify Cataloger
2 participants
@cdupuis @crazy-max