-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading repositories with submodules is repeated. Failed to clone submodule from googlesource #300
Loading repositories with submodules is repeated. Failed to clone submodule from googlesource #300
Comments
@MarshalX Yes maybe authentication header is sent to submodules as well, that's why you have this kind of issue. Looks like a bug on buildkit. WDYT @tonistiigi? In the meantime you can use the Path context: jobs:
build_push_to_registry:
name: Push Docker image to GitHub Packages
runs-on: ubuntu-latest
steps:
- name: Check out the repo
uses: actions/checkout@v2
with:
submodules: recursive
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
- name: Login to GitHub Container Registry
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.CR_PAT }}
- name: Push to GitHub Packages
uses: docker/build-push-action@v2
with:
context: .
file: build/manylinux/Dockerfile
push: true
tags: tgcalls/manylinux:latest |
@crazy-max Thank you very much for such a quick response! Thanks for solving my problem! I am sorry that I slightly missed the repository for creating Issue. Got it after seeing the command that runs build-push-action |
@MarshalX Can you make a test with: - name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
with:
driver-opts: image=crazymax/buildkit:git-token-scope |
https://github.com/moby/buildkit/releases/tag/v0.8.2n is out and this should be fixed |
Signed-off-by: deadprogram <[email protected]>
Use context option as described here: docker/build-push-action#300
@crazy-max could you please explain why having |
If |
I see, thanks. Well, I actually came across this issue because things didn't work:
... and now I understand why having a |
@roymiloh It doesn't checkout submodules by default: https://github.com/actions/checkout/#usage # Whether to checkout submodules: `true` to checkout submodules or `recursive` to
# recursively checkout submodules.
#
# When the `ssh-key` input is not provided, SSH URLs beginning with
# `[email protected]:` are converted to HTTPS.
#
# Default: false
submodules: '' |
My workflow:
The second way:
My repository is private. It has several submodules. They are all public. Some on github, others on google. The checkout proceeds normally in two ways (see above). When trying to use build-push-action (with and without Buildx step), it cannot clone google submodules. Probably something is being mixed into the request. For example, some kind of token that Google cannot validate. Requests do not go through. Do not clone sambmodules...
Logs:
As you can see the repository https://chromium.googlesource.com/webm/libvpx/ and https://chromium.googlesource.com/libyuv/libyuv/ is public.
Thanks!
The text was updated successfully, but these errors were encountered: