v6 cannot be used with actions/download-artifact@v4

[kateinoigakukun]

Contributing guidelines

• I've read the contributing guidelines and wholeheartedly agree

I've found a bug, and:

• The documentation does not mention anything about my problem
• There are no open or closed issues that are related to my problem

Description

After updating docker/build-push-action to v6, we started observing the following error at actions/download-artifact step.

Unable to download artifact(s): Unable to download and extract artifact: Artifact download failed after 5 retries.

I guess something in the build summary uploading feature is incompatible with actions/download-artifact.

You can reproduce the problem with this https://github.com/kateinoigakukun/gh-actions-sandbox/actions/runs/9737812232/workflow

Expected behaviour

actions/download-artifact can download all artifacts even with this action.

Actual behaviour

actions/download-artifact fails while trying to download all artifacts

Repository URL

No response

Workflow run URL

No response

YAML workflow

name: Docker Build

on:
  workflow_dispatch:

jobs:
  docker:
    runs-on: ubuntu-latest
    steps:
      - uses: docker/build-push-action@v6
  post-job:
    runs-on: ubuntu-latest
    needs: [docker]
    steps:
      - uses: actions/download-artifact@v4

Workflow logs

No response

BuildKit logs

No response

Additional info

No response

[crazy-max]

Thanks for your feedback, looking at the workflow:

name: Docker Build

on:
  workflow_dispatch:

jobs:
  docker:
    runs-on: ubuntu-latest
    steps:
      - uses: docker/build-push-action@v6
  post-job:
    runs-on: ubuntu-latest
    needs: [docker]
    steps:
      - uses: actions/download-artifact@v4

It seems actions/download-artifact@v4 downloads all available artifacts within the workflow if name and pattern are not set: https://github.com/actions/download-artifact?tab=readme-ov-file#download-all-artifacts

If the name input parameter is not provided, all artifacts will be downloaded. To differentiate between downloaded artifacts, by default a directory denoted by the artifacts name will be created for each individual artifact. This behavior can be changed with the merge-multiple input parameter.

And will therefore try to download the .dockerbuild file uploaded by our action: https://github.com/kateinoigakukun/gh-actions-sandbox/actions/runs/9737812232/job/26870430716#step:2:13

Starting download of artifact to: /home/runner/work/gh-actions-sandbox/gh-actions-sandbox/kateinoigakukun~gh-actions-sandbox~8P1DEG.dockerbuild

I wonder if this is because we are setting the content disposition header when uploading the file to the store: https://github.com/docker/actions-toolkit/blob/fe9937dd36b64d2090fbfec40e144944ae390a12/src/github.ts#L159

I will take a closer look.

[crazy-max]

After enabling debug it seems it fails because the file is not a valid zip which makes sense because in your case it's a gzip:

• build-push-action/src/main.ts

  Line 162 in af64c4e

  mimeType: 'application/gzip',

• https://github.com/docker/actions-toolkit/blob/fe9937dd36b64d2090fbfec40e144944ae390a12/src/github.ts#L162

##[debug]Failed to download artifact after 1 retries due to Not a valid zip file. Retrying in 5 seconds...
##[debug]Failed to download artifact after 2 retries due to Not a valid zip file. Retrying in 5 seconds...
##[debug]Failed to download artifact after 3 retries due to Not a valid zip file. Retrying in 5 seconds...
##[debug]Failed to download artifact after 4 retries due to Not a valid zip file. Retrying in 5 seconds...
##[debug]Failed to download artifact after 5 retries due to Not a valid zip file. Retrying in 5 seconds...
Error: Unable to download artifact(s): Unable to download and extract artifact: Artifact download failed after 5 retries.

Seems related to actions/download-artifact#328

[crazy-max]

Found a way to mitigate this issue when using actions/download-artifact: actions/download-artifact#328 (comment)

Will see for maintainers feedback.

[hegerdes]

Had the same issue.

If you remove the build summary artifacts it works again. I think you can disable it with setting DOCKER_BUILD_NO_SUMMARY=true

[crazy-max]

If you remove the build summary artifacts it works again. I think you can disable it with setting DOCKER_BUILD_NO_SUMMARY=true

Since https://github.com/docker/build-push-action/releases/tag/v6.3.0 you can also just set DOCKER_BUILD_RECORD_UPLOAD: false to disable build record upload as GitHub artifact and keep summary generation: https://github.com/docker/build-push-action?tab=readme-ov-file#environment-variables

[saisatishkarra]

An [example of reproduced issue](https://github.com/saisatishkarra/public-shared-actions/actions/runs/9781049546/job/27004202651#step:2:16 to download all assets using actions/download@v4 after the docker/build-push-action@v6 job
An quick run by bumping to v6.3.0 also doesn't work UNTIL a new run with change is made to disable build record upload.

[crazy-max]

UNTIL a new run with change is made to disable docker summary report starting v6.

I think you mean build record upload not "disable docker summary report" but yeah that's it.

[hegerdes]

@crazy-max May I suggest to update the release notes for v6 to mention the incompatibility with download-artifacts and to promote the new environment flag to disable that behavior instead of a deprecated one?

Manny people will get the dependabot PR to update the action but it will serve outdated/inakkurate information for compatibility if it is not mentioned in the release notes.
For future features an opt-in testing phase might be a great idea.

[ahatzz11]

@crazy-max Has there been any update to this? GitHub is going to be deprecating the old actions on December 5th blog post so people will be required to use v4. Having these docker build artifacts break downloads is going to start causing a larger range of issues.

[crazy-max]

@ahatzz11 Will reach GitHub staff and keep you posted.