-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: apply license headers #204
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
- Coverage 70.75% 66.37% -4.38%
==========================================
Files 44 44
Lines 2595 3215 +620
==========================================
+ Hits 1836 2134 +298
- Misses 457 779 +322
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bccc687
to
6fd73fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need to outdent all of the comments in Go files to make the linter happy 😅
How do the templates work?
Do we need to include the year in the copyright notice in each file? Do we need to update them every year?
I was questioning this, I went with the template that was used in containerd per @thaJeztah's suggestion in the ticket we created. I was planing on just ignoring the linter for these.
See https://github.com/containerd/ltag
Per suggestion and the ticket description, we only need to update copyright when we modify the file with the copyright notice in it. I just re-read it and it seems the year is optional, so maybe we should just remove the year entirely? |
FWIW, the An alternative is a package provided by Google to do the same; I know we use that in this repository; PR below may help with the implementation; |
removed year |
summary