This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Remove poll-breaking assertion in e2e tests #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #784 +/- ##
=======================================
Coverage 70.32% 70.32%
=======================================
Files 67 67
Lines 3740 3740
=======================================
Hits 2630 2630
Misses 762 762
Partials 348 348Continue to review full report at Codecov.
|
zappy-shu
changed the title
Removed assertion of local-in-docker command result when running e2e tests in swarm. This function is only used by the compatibility tests which does it's own assertion in a poll. The removed assertion was breaking the poll flow stopping the test from being able to retry. Signed-off-by: Nick Adcock <[email protected]>
zappy-shu
force-pushed
the
add-logs-to-e2e-tests
branch
from
6620ec9
to
c58a172
Compare
ndeloof
approved these changes
Dec 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes #786
Removed assertion of local-in-docker command result when running e2e tests in swarm. This function is only used by the compatibility tests which does it's own assertion in a poll (
app/e2e/compatibility_test.go
Line 138 in 1cfb232
- How I did it
Removed
result.Assertin therunLocalCmdwhich is used in theTestBackwardsCompatibilityV1to check if the app's port has been updated. Note thatTestBackwardsCompatibilityV1is the only place that therunLocalCmdis used either throughrunner.localCmdorrunner.execCmd.- How to verify it
Run the
TestBackwardsCompatibilityV1e2e test:make E2E_TESTS=TestBackwardsCompatibilityV1 -f docker.Makefile test-e2eThe CI will check if all e2e tests pass
- A picture of a cute animal (not mandatory)