-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker/install: Support rootless #485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
force-pushed
the
docker-install-rootless
branch
7 times, most recently
from
November 5, 2024 15:46
324f9c9
to
bfd2263
Compare
Missing |
vvoland
force-pushed
the
docker-install-rootless
branch
from
November 5, 2024 15:51
bfd2263
to
f85f73e
Compare
It lost the PATH when |
vvoland
force-pushed
the
docker-install-rootless
branch
from
November 5, 2024 15:55
f85f73e
to
293c0ee
Compare
Might need |
vvoland
force-pushed
the
docker-install-rootless
branch
6 times, most recently
from
November 6, 2024 12:57
409eeff
to
d7de9c8
Compare
vvoland
changed the title
[WIP] docker/install: Support rootless
docker/install: Support rootless
Nov 6, 2024
Ready for review @crazy-max |
crazy-max
reviewed
Nov 6, 2024
vvoland
force-pushed
the
docker-install-rootless
branch
from
November 6, 2024 16:32
62577a5
to
ce839e8
Compare
vvoland
force-pushed
the
docker-install-rootless
branch
from
November 6, 2024 16:55
b1a64ac
to
2afeeaa
Compare
Add support for running a rootless daemon. Currently only Linux host is supported. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
docker-install-rootless
branch
from
November 6, 2024 17:02
2afeeaa
to
2d2bc84
Compare
crazy-max
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for running a rootless daemon. Currently only Linux host is supported.