Merge pull request #176 from elias-lundgren/fix-env-quoting

Remove quotes around env variable name in resolveBuildSecretEnv
docker · Oct 2, 2023 · f5c9bb7 · f5c9bb7
2 parents 9d75f8f + d3d7271
commit f5c9bb7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/__tests__/buildx/inputs.test.ts b/__tests__/buildx/inputs.test.ts
@@ -186,7 +186,7 @@ describe('resolveBuildSecret', () => {
   ])('given %p key and %p env', async (kvp: string, exKey: string, exValue: string, error: Error | null) => {
     try {
       const secret = Inputs.resolveBuildSecretEnv(kvp);
-      expect(secret).toEqual(`id=${exKey},env="${exValue}"`);
+      expect(secret).toEqual(`id=${exKey},env=${exValue}`);
     } catch (e) {
       // eslint-disable-next-line jest/no-conditional-expect
       expect(e.message).toEqual(error?.message);

diff --git a/src/buildx/inputs.ts b/src/buildx/inputs.ts
@@ -85,7 +85,7 @@ export class Inputs {
   public static resolveBuildSecretEnv(kvp: string): string {
     const [key, value] = parseKvp(kvp);
 
-    return `id=${key},env="${value}"`;
+    return `id=${key},env=${value}`;
   }
 
   public static resolveBuildSecret(kvp: string, file: boolean): string {