Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "wp-config-docker.php" to non-beta (5.7 GA) #572

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

tianon
Copy link
Member

@tianon tianon commented Mar 9, 2021

See #557 for details on this functionality. 👍

(GitHub is showing the diff in a strange way, but the new docker-entrypoint.sh is literally docker-entrypoint-ng.sh renamed 🤦)

@tianon
Copy link
Member Author

tianon commented Mar 9, 2021

(This is the change we comitted to make in #557 that needs to be merged before we send 24c4469 downstream. 👍)

@tianon tianon force-pushed the un-beta branch 2 times, most recently from 4f2e047 to 0e07385 Compare March 9, 2021 22:10
@tianon tianon merged commit fb920c6 into docker-library:master Mar 10, 2021
@tianon tianon deleted the un-beta branch March 10, 2021 00:54
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 10, 2021
Changes:

- docker-library/wordpress@fb920c6: Merge pull request docker-library/wordpress#572 from infosiftr/un-beta
- docker-library/wordpress@891b710: Move "wp-config-docker.php" to non-beta (5.7 GA)
- docker-library/wordpress@24c4469: Update latest to 5.7.0
- docker-library/wordpress@59404ef: Update beta to 5.7.0
@tianon
Copy link
Member Author

tianon commented Mar 10, 2021

Just to make sure the important bits / migration path for users are in more places they might look when things don't seem to be working the same way they used to, see #557 (comment):

For users who are changing WORDPRESS_* variables and expecting our docker-entrypoint.sh to update them, the "migration" path is to remove your wp-config.php file and let the new entrypoint copy in the updated version, and everything will "just work" from then on.

@youknowriad
Copy link

Noting that this PR broken @wordpress/env or wp-env. We're still trying to understand it exactly here WordPress/gutenberg#29752

@damnMeddlingKid
Copy link

@tianon This PR removes the code to create the database in the entrypoint, is that intended behaviour going forward ?. if so we should update the docs at https://hub.docker.com/_/wordpress?tab=tags

yosifkit added a commit to infosiftr/docker-library-docs that referenced this pull request Mar 12, 2021
yosifkit added a commit to infosiftr/docker-library-docs that referenced this pull request Mar 12, 2021
@tianon
Copy link
Member Author

tianon commented Mar 13, 2021

Yep, that was intentional -- see docker-library/docs#1892, especially docker-library/docs#1892 (comment):

Creating the database should not have been the job of the WordPress container since that means the database user has more access than it needs to store WordPress data.

Both the mysql and mariadb images have support for creating a database and user with limited access (as is done in the example WordPress stack.yml here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants