Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4.0.0-beta.1 pre-release #713

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

yosifkit
Copy link
Member

@yosifkit yosifkit commented Jul 16, 2024

🎉 A new RabbitMQ release series, 4.0. Use latest OS releases (Ubuntu 24.04 LTS and Alpine 3.20); bump openssl to 3.3.x, the series used in testing upstream RabbitMQ: #712 (comment)

closes #712

@LaurentGoderre
Copy link
Member

Maybe not a huge issue but the version being reported for RabbitMQ here is 3.13.0+424.g256fd8e not 4.0.0-beta.1

@yosifkit
Copy link
Member Author

That's the version detected by the syft SBOM scanner? I would guess that is just because it is a pre-release. But I'm not familiar enough with the RabbitMQ build/release process to know where that gets injected.

@LaurentGoderre
Copy link
Member

Except for the case of RabbitMQ, these are the versions that are defined explicitly in the packages so it's not a detection issue.

@yosifkit
Copy link
Member Author

Yeah, it should be fine. I think it is still accurate and should be correct by the stable release.

I think it could be related to the version in MODULE.bazel, but I don't really know since there is also a version in rabbitmq.bzl.

@yosifkit yosifkit merged commit 53454e0 into docker-library:master Jul 18, 2024
11 checks passed
@yosifkit yosifkit deleted the 4.0-pre-release branch July 18, 2024 21:58
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jul 18, 2024
Changes:

- docker-library/rabbitmq@53454e0: Merge pull request docker-library/rabbitmq#713 from infosiftr/4.0-pre-release
- docker-library/rabbitmq@3881658: Add 4.0-beta.1 pre-release
@michaelklishin
Copy link
Collaborator

michaelklishin commented Jul 19, 2024

Maybe not a huge issue but the version being reported for RabbitMQ here is 3.13.0+424.g256fd8e not 4.0.0-beta.1

That has nothing to do with the image. Team RabbitMQ has decided to ship the first beta like so. It does not prevent anyone from testing what we actually want to see tested. What everyone in the community needs tested early and often.

@michaelklishin
Copy link
Collaborator

michaelklishin commented Jul 19, 2024

@yosifkit setting PRODUCT_VERSION (an env variable) when the node is started would override the version. However, this is something that should be addressed in RabbitMQ's own release pipelines. Right now the version of development releases comes from the most recent tag "on the main branch" (discoverable from it using git-describe --tags), even though we no longer produce releases straight off of main.

For "final" releases this default does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a 4.0 (preview) flavor
3 participants