Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "--with-pear" in 7.4 #851

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Conversation

tianon
Copy link
Member

@tianon tianon commented Jun 25, 2019

This means that pear and pecl will be available for PHP 7.4+, but will be removed in PHP 8+ (see https://externals.io/message/103977 for upstream discussion around this deprecation).

I tested the 8+ changes to this script by creating a few fake "8.0" bits in the script itself (fake possibles version, etc) and verified that the result is as expected.

Closes #846

This means that `pear` and `pecl` will be available for PHP 7.4+, but *will be removed* in PHP 8+ (see https://externals.io/message/103977 for upstream discussion around this deprecation).

I tested the 8+ changes to this script by creating a few fake "8.0" bits in the script itself (fake `possibles` version, etc) and verified that the result is as expected.
@tianon
Copy link
Member Author

tianon commented Jun 26, 2019

Green, finally!! 🎈

@yosifkit yosifkit merged commit eaa29e4 into docker-library:master Jun 26, 2019
@yosifkit yosifkit deleted the with-pear branch June 26, 2019 23:49
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 27, 2019
Changes:

- docker-library/php@bbcc3db: Update to 7.4.0alpha2
- docker-library/php@eaa29e4: Merge pull request docker-library/php#851 from infosiftr/with-pear
- docker-library/php@e2331f5: Add "--with-pear" in 7.4
- docker-library/php@04e67dc: Merge pull request docker-library/php#850 from petk/patch-php-7.4-alpha
- docker-library/php@820403d: Also remove "update.sh" bits for ARGON2 hack removal
- docker-library/php@894ee59: Remove the Alpine argon2 library fix
- docker-library/php@2e2df06: Merge pull request docker-library/php#843 from J0WI/curl
- docker-library/php@250c2d8: Add "set -u" and more consistency
- docker-library/php@82d590a: Use already available curl and consistent code style
- docker-library/php@c0f68b2: Merge pull request docker-library/php#845 from J0WI/alpine10
- docker-library/php@27cfb71: Update default to Alpine 3.10
- docker-library/php@3802051: Add Alpine 3.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PECL not working on php:7.4-rc-fpm-alpine3.9
2 participants