Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the comments from being within a command, #337

Closed
wants to merge 1 commit into from
Closed

Remove the comments from being within a command, #337

wants to merge 1 commit into from

Conversation

martynbristow
Copy link

Docker rejects multi-line commands which contain a comment:
The error is:
Martyns-MBP:5.6 martyn$ docker build .
Sending build context to Docker daemon 96.77 kB
Error response from daemon: Unknown instruction: --ENABLE-FTP

Or:
Martyns-MBP:5.6 martyn$ docker build .
Sending build context to Docker daemon 96.77 kB
Error response from daemon: Unknown instruction: &&

@martynbristow
Copy link
Author

This will solve issue: #336

@yosifkit
Copy link
Member

yosifkit commented Dec 1, 2016

I think we'd rather fix this in docker itself, since 1.13 is still a release candidate and effects more than just the php Dockerfile. We have filed an issue: moby/moby#29005.

@tianon
Copy link
Member

tianon commented Dec 1, 2016

Yeah, this is something that will be fixed in Docker itself before 1.13 GA. 👍

@tianon tianon closed this Dec 1, 2016
Luoc888

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants