[nats] Release v2.3.0 #10413
Merged
[nats] Release v2.3.0 #10413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the delay, I am hesitant to merge this since our servers have been unable to build Alpine 3.14 based images and we're still working on that (#10379 (comment)). If you don't mind the Alpine (and |
|
@yosifkit Let me check with the rest of my team to see if we should downgrade back to alpine 3.13? Any idea of how long it would take to sort this out? |
|
@yosifkit In order to decide if I resubmit PR sticking with Alpine 3.13, it would help if I could get an idea on how long it would take to resolve the issue with Alpine 3.14 (and "I don't know" IS a valid answer ;-)). As a side note, I am able to build the alpine docker image of NATS, but not sure if the issue is related to your build process or with any image depending on alpine 3.14: |
|
I'm not entirely certain when the builders will be fixed; I'm hopeful that we can get it done before this weekend. Yeah, I can build locally as well, but our builder servers need an updated Docker in order to get opencontainers/runc#2750. Unfortunately we don't just use the binaries released by Docker since we have more architectures than they release for and we want them all to be using the same process to install updates. |
|
@yosifkit Thank you for the update. I am going to downgrade to alpine 3.13 and update this PR if you don't mind. We have released yesterday and users are already asking about the docker image ;-) PS: let me know if it is better to close this PR and open a new one. |
|
Updating this PR is great. Use a force push if you like. |
Details can be found [here](https://github.com/nats-io/nats-server/releases/tag/v2.3.0) Doc PR: docker-library/docs#1981 Signed-off-by: Ivan Kozlovic <[email protected]>
Diff for 24a7371:diff --git a/_bashbrew-cat b/_bashbrew-cat
index 88ee60f..679bdac 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,30 +1,30 @@
Maintainers: Derek Collison <[email protected]> (@derekcollison), Ivan Kozlovic <[email protected]> (@kozlovic), Waldemar Salinas <[email protected]> (@wallyqs), Jaime Piña <[email protected]> (@variadico)
GitRepo: https://github.com/nats-io/nats-docker.git
-GitCommit: 7acef1794d5a3e92344e681cbcae7906ad8194e4
+GitCommit: ee731036f3e5c43c7daaef2614b329f772ddf808
-Tags: 2.2.6-alpine3.13, 2.2-alpine3.13, 2-alpine3.13, alpine3.13, 2.2.6-alpine, 2.2-alpine, 2-alpine, alpine
+Tags: 2.3.0-alpine3.13, 2.3-alpine3.13, 2-alpine3.13, alpine3.13, 2.3.0-alpine, 2.3-alpine, 2-alpine, alpine
Architectures: amd64, arm32v6, arm32v7, arm64v8
-Directory: 2.2.6/alpine3.13
+Directory: 2.3.0/alpine3.13
-Tags: 2.2.6-nanoserver-1809, 2.2-nanoserver-1809, 2-nanoserver-1809, nanoserver-1809
-SharedTags: 2.2.6-nanoserver, 2.2-nanoserver, 2-nanoserver, nanoserver, 2.2.6, 2.2, 2, latest
+Tags: 2.3.0-nanoserver-1809, 2.3-nanoserver-1809, 2-nanoserver-1809, nanoserver-1809
+SharedTags: 2.3.0-nanoserver, 2.3-nanoserver, 2-nanoserver, nanoserver, 2.3.0, 2.3, 2, latest
Architectures: windows-amd64
-Directory: 2.2.6/nanoserver-1809
+Directory: 2.3.0/nanoserver-1809
Constraints: nanoserver-1809, windowsservercore-1809
-Tags: 2.2.6-scratch, 2.2-scratch, 2-scratch, scratch, 2.2.6-linux, 2.2-linux, 2-linux, linux
-SharedTags: 2.2.6, 2.2, 2, latest
+Tags: 2.3.0-scratch, 2.3-scratch, 2-scratch, scratch, 2.3.0-linux, 2.3-linux, 2-linux, linux
+SharedTags: 2.3.0, 2.3, 2, latest
Architectures: amd64, arm32v6, arm32v7, arm64v8
-Directory: 2.2.6/scratch
+Directory: 2.3.0/scratch
-Tags: 2.2.6-windowsservercore-1809, 2.2-windowsservercore-1809, 2-windowsservercore-1809, windowsservercore-1809
-SharedTags: 2.2.6-windowsservercore, 2.2-windowsservercore, 2-windowsservercore, windowsservercore
+Tags: 2.3.0-windowsservercore-1809, 2.3-windowsservercore-1809, 2-windowsservercore-1809, windowsservercore-1809
+SharedTags: 2.3.0-windowsservercore, 2.3-windowsservercore, 2-windowsservercore, windowsservercore
Architectures: windows-amd64
-Directory: 2.2.6/windowsservercore-1809
+Directory: 2.3.0/windowsservercore-1809
Constraints: windowsservercore-1809
-Tags: 2.2.6-windowsservercore-ltsc2016, 2.2-windowsservercore-ltsc2016, 2-windowsservercore-ltsc2016, windowsservercore-ltsc2016
-SharedTags: 2.2.6-windowsservercore, 2.2-windowsservercore, 2-windowsservercore, windowsservercore
+Tags: 2.3.0-windowsservercore-ltsc2016, 2.3-windowsservercore-ltsc2016, 2-windowsservercore-ltsc2016, windowsservercore-ltsc2016
+SharedTags: 2.3.0-windowsservercore, 2.3-windowsservercore, 2-windowsservercore, windowsservercore
Architectures: windows-amd64
-Directory: 2.2.6/windowsservercore-ltsc2016
+Directory: 2.3.0/windowsservercore-ltsc2016
Constraints: windowsservercore-ltsc2016
diff --git a/_bashbrew-list b/_bashbrew-list
index dc9d590..cd744f6 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -8,26 +8,26 @@ nats:2-scratch
nats:2-windowsservercore
nats:2-windowsservercore-1809
nats:2-windowsservercore-ltsc2016
-nats:2.2
-nats:2.2-alpine
-nats:2.2-alpine3.13
-nats:2.2-linux
-nats:2.2-nanoserver
-nats:2.2-nanoserver-1809
-nats:2.2-scratch
-nats:2.2-windowsservercore
-nats:2.2-windowsservercore-1809
-nats:2.2-windowsservercore-ltsc2016
-nats:2.2.6
-nats:2.2.6-alpine
-nats:2.2.6-alpine3.13
-nats:2.2.6-linux
-nats:2.2.6-nanoserver
-nats:2.2.6-nanoserver-1809
-nats:2.2.6-scratch
-nats:2.2.6-windowsservercore
-nats:2.2.6-windowsservercore-1809
-nats:2.2.6-windowsservercore-ltsc2016
+nats:2.3
+nats:2.3-alpine
+nats:2.3-alpine3.13
+nats:2.3-linux
+nats:2.3-nanoserver
+nats:2.3-nanoserver-1809
+nats:2.3-scratch
+nats:2.3-windowsservercore
+nats:2.3-windowsservercore-1809
+nats:2.3-windowsservercore-ltsc2016
+nats:2.3.0
+nats:2.3.0-alpine
+nats:2.3.0-alpine3.13
+nats:2.3.0-linux
+nats:2.3.0-nanoserver
+nats:2.3.0-nanoserver-1809
+nats:2.3.0-scratch
+nats:2.3.0-windowsservercore
+nats:2.3.0-windowsservercore-1809
+nats:2.3.0-windowsservercore-ltsc2016
nats:alpine
nats:alpine3.13
nats:latest
diff --git a/nats_alpine/Dockerfile b/nats_alpine/Dockerfile
index 666ca45..92d4048 100644
--- a/nats_alpine/Dockerfile
+++ b/nats_alpine/Dockerfile
@@ -1,28 +1,28 @@
FROM alpine:3.13
-ENV NATS_SERVER 2.2.6
+ENV NATS_SERVER 2.3.0
RUN set -eux; \
apkArch="$(apk --print-arch)"; \
case "$apkArch" in \
- aarch64) natsArch='arm64'; sha256='779d7f363fb0244071e67bf146c7169a8e3c35af2746c0a01323a3c5fd12bf31' ;; \
- armhf) natsArch='arm6'; sha256='ed7211f56fa3928e3664ed92df632b0e7480bd1b4a91c239cb26a0f55831c815' ;; \
- armv7) natsArch='arm7'; sha256='a55335b1329248912e80d8e68b5dd6b6a48c4742de089c4226f503d7e8357f2c' ;; \
- x86_64) natsArch='amd64'; sha256='fc67ce0b4c748fa16ff92414c7d6be18a9285824c21d9629684c0093cf074f77' ;; \
- x86) natsArch='386'; sha256='386811034531cea6e794e4764fdd70b0b948fdf7212064e8c176663992c46f2e' ;; \
+ aarch64) natsArch='arm64'; sha256='139521edba99389436c95b12b93aa4e7fbc0b2d07ac8584902cfc4d417773d3c' ;; \
+ armhf) natsArch='arm6'; sha256='ebc1907729fa322c1191ce605e55c54f063bacf5f811802e8a32076210131975' ;; \
+ armv7) natsArch='arm7'; sha256='30476c49ca5f1404b7bc3536ad325da9d8c7eb6f733c1b992fc20bf288e15eeb' ;; \
+ x86_64) natsArch='amd64'; sha256='3a6097371169d750d73b643f2d4644b99e575e966a99e8458426bbfccb8fda7b' ;; \
+ x86) natsArch='386'; sha256='37715ed91c4a3698fde4ba69f2bf8fd3cd1346347bbab97f3af176cdbcb47b05' ;; \
*) echo >&2 "error: $apkArch is not supported!"; exit 1 ;; \
esac; \
\
- wget -O nats-server.zip "https://github.com/nats-io/nats-server/releases/download/v${NATS_SERVER}/nats-server-v${NATS_SERVER}-linux-${natsArch}.zip"; \
- echo "${sha256} *nats-server.zip" | sha256sum -c -; \
+ wget -O nats-server.tar.gz "https://github.com/nats-io/nats-server/releases/download/v${NATS_SERVER}/nats-server-v${NATS_SERVER}-linux-${natsArch}.tar.gz"; \
+ echo "${sha256} *nats-server.tar.gz" | sha256sum -c -; \
\
apk add --no-cache ca-certificates; \
- apk add --no-cache --virtual buildtmp unzip; \
+ apk add --no-cache --virtual buildtmp; \
\
- unzip nats-server.zip "nats-server-v${NATS_SERVER}-linux-${natsArch}/nats-server"; \
- rm nats-server.zip; \
+ tar -xf nats-server.tar.gz; \
+ rm nats-server.tar.gz; \
mv "nats-server-v${NATS_SERVER}-linux-${natsArch}/nats-server" /usr/local/bin; \
- rmdir "nats-server-v${NATS_SERVER}-linux-${natsArch}"; \
+ rm -rf "nats-server-v${NATS_SERVER}-linux-${natsArch}"; \
\
apk del --no-cache --no-network buildtmp
diff --git a/nats_linux/Dockerfile b/nats_linux/Dockerfile
index 2ef7403..2b0d726 100644
--- a/nats_linux/Dockerfile
+++ b/nats_linux/Dockerfile
@@ -1,5 +1,5 @@
FROM scratch
-COPY --from=nats:2.2.6-alpine3.13 /usr/local/bin/nats-server /nats-server
+COPY --from=nats:2.3.0-alpine3.13 /usr/local/bin/nats-server /nats-server
COPY nats-server.conf /nats-server.conf
EXPOSE 4222 8222 6222
ENTRYPOINT ["/nats-server"]
diff --git a/nats_nanoserver-1809/Dockerfile b/nats_nanoserver-1809/Dockerfile
index 1b332bd..cbea642 100644
--- a/nats_nanoserver-1809/Dockerfile
+++ b/nats_nanoserver-1809/Dockerfile
@@ -2,7 +2,7 @@ FROM mcr.microsoft.com/windows/nanoserver:1809
ENV NATS_DOCKERIZED 1
-COPY --from=nats:2.2.6-windowsservercore-1809 C:\\nats-server.exe C:\\nats-server.exe
+COPY --from=nats:2.3.0-windowsservercore-1809 C:\\nats-server.exe C:\\nats-server.exe
COPY nats-server.conf C:\\nats-server.conf
EXPOSE 4222 8222 6222
diff --git a/nats_windowsservercore-1809/Dockerfile b/nats_windowsservercore-1809/Dockerfile
index 1dcdad9..1262f66 100644
--- a/nats_windowsservercore-1809/Dockerfile
+++ b/nats_windowsservercore-1809/Dockerfile
@@ -4,9 +4,9 @@ FROM mcr.microsoft.com/windows/servercore:1809
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop';"]
ENV NATS_DOCKERIZED 1
-ENV NATS_SERVER 2.2.6
+ENV NATS_SERVER 2.3.0
ENV NATS_SERVER_DOWNLOAD https://github.com/nats-io/nats-server/releases/download/v${NATS_SERVER}/nats-server-v${NATS_SERVER}-windows-amd64.zip
-ENV GIT_DOWNLOAD_SHA256 c1712f41e4e811027701a036b6ff67b1f09fb298b0674098b26f875d37e709b2
+ENV NATS_SERVER_SHASUM 4cf3cad0f3fc635a7be429ab13d852b1eea41c8f81b5d9ef7f21d93dd99a1f6f
RUN Set-PSDebug -Trace 2
@@ -14,8 +14,8 @@ RUN Write-Host ('downloading from {0} ...' -f $env:NATS_SERVER_DOWNLOAD); \
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; \
Invoke-WebRequest -Uri $env:NATS_SERVER_DOWNLOAD -OutFile nats.zip; \
\
- Write-Host ('verifying sha256 ({0}) ...' -f $env:GIT_DOWNLOAD_SHA256); \
- if ((Get-FileHash nats.zip -Algorithm sha256).Hash -ne $env:GIT_DOWNLOAD_SHA256) { \
+ Write-Host ('verifying sha256 ({0}) ...' -f $env:NATS_SERVER_SHASUM); \
+ if ((Get-FileHash nats.zip -Algorithm sha256).Hash -ne $env:NATS_SERVER_SHASUM) { \
Write-Host 'FAILED!'; \
exit 1; \
}; \
diff --git a/nats_windowsservercore-ltsc2016/Dockerfile b/nats_windowsservercore-ltsc2016/Dockerfile
index 03d0b1c..dd8ab47 100644
--- a/nats_windowsservercore-ltsc2016/Dockerfile
+++ b/nats_windowsservercore-ltsc2016/Dockerfile
@@ -4,9 +4,9 @@ FROM mcr.microsoft.com/windows/servercore:ltsc2016
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop';"]
ENV NATS_DOCKERIZED 1
-ENV NATS_SERVER 2.2.6
+ENV NATS_SERVER 2.3.0
ENV NATS_SERVER_DOWNLOAD https://github.com/nats-io/nats-server/releases/download/v${NATS_SERVER}/nats-server-v${NATS_SERVER}-windows-amd64.zip
-ENV GIT_DOWNLOAD_SHA256 c1712f41e4e811027701a036b6ff67b1f09fb298b0674098b26f875d37e709b2
+ENV NATS_SERVER_SHASUM 4cf3cad0f3fc635a7be429ab13d852b1eea41c8f81b5d9ef7f21d93dd99a1f6f
RUN Set-PSDebug -Trace 2
@@ -14,8 +14,8 @@ RUN Write-Host ('downloading from {0} ...' -f $env:NATS_SERVER_DOWNLOAD); \
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; \
Invoke-WebRequest -Uri $env:NATS_SERVER_DOWNLOAD -OutFile nats.zip; \
\
- Write-Host ('verifying sha256 ({0}) ...' -f $env:GIT_DOWNLOAD_SHA256); \
- if ((Get-FileHash nats.zip -Algorithm sha256).Hash -ne $env:GIT_DOWNLOAD_SHA256) { \
+ Write-Host ('verifying sha256 ({0}) ...' -f $env:NATS_SERVER_SHASUM); \
+ if ((Get-FileHash nats.zip -Algorithm sha256).Hash -ne $env:NATS_SERVER_SHASUM) { \
Write-Host 'FAILED!'; \
exit 1; \
}; \
|
|
@yosifkit Done! |
|
@yosifkit We are going to do a v2.3.1 release today and wanted to know if the issue with Alpine 3.14 is resolved or if we should stick to Alpine 3.13 for now. |
|
Builders are updated, so it is fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details can be found here
Doc PR: docker-library/docs#1981
Signed-off-by: Ivan Kozlovic [email protected]