-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Officially deprecate "rails" #503
Conversation
Rails itself is included in the |
@@ -0,0 +1,19 @@ | |||
This image is officially deprecated in favor of [the standard `ruby` image](https://hub.docker.com/_/ruby/), and will receive no further updates. Please adjust your usage accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should give a leniency period rather than this abrupt end. How about an EOL of maybe 6 months from now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was planning on doing so, but calling it out explicitly and giving it a specific EOL date probably makes sense. 👍
Yeah, I suppose it is somewhat useful for initializing a new project... So perhaps we just deprecate the As for the deps, they're not actually universally required, so I think the fact that this text explicitly calls out "for a project using PostgreSQL" is probably good enough -- folks should be able to figure out that if they use MySQL, they need to include whatever their bindings need for that to work... 😄 (but maybe those client bindings make some sense in |
Given what it is (just a framework), and looking through https://github.com/search?l=dockerfile&q=%22FROM+rails%22&type=Code, I think it's time we finally cut the cord.
I've replaced: ... and will receive no further updates. with: and will receive no further updates after 2016-12-31 (Dec 31, 2016). Happy to bikeshed on a different date, but I figured setting it somewhere in the far future should give a plenty big window for existing users (if we merge soon, that's over half a year / 6 months). It seems a little long, but I didn't think this discussion was quite open and shut yet so it can serve as a concrete point to discuss around. 😄 |
LGTM |
I though about the possibility of adding the sql clients from the rails image to buildpack-deps so that all language stacks can use them. On $ docker images buildpack-deps
REPOSITORY TAG IMAGE ID CREATED SIZE
buildpack-deps temp 031a9584969b 5 seconds ago 655.4 MB
buildpack-deps latest f9f7b5cfe736 10 days ago 610 MB |
See docker-library#503 for the justification of the deprecation of `rails`, which all applies here as well.
Given what it is (just a framework), and looking through https://github.com/search?l=dockerfile&q=%22FROM+rails%22&type=Code, I think it's time we finally cut the cord.