This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
forked from moby/moby
-
Notifications
You must be signed in to change notification settings - Fork 424
WIP [18.09 backport] Bump swarmkit to a84c01f #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibor Vass <[email protected]> (cherry picked from commit 82388d0) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Relevant changes; - swarmkit#2681 Handle an edge case in CA rotation where we reclaim CA service from an external CA - swarmkit#2750 Use gometalinter; switch from x/net/context -> context Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 8dedcb8) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Anshul Pundir <[email protected]> (cherry picked from commit 93e1c5a) Signed-off-by: Sebastiaan van Stijn <[email protected]>
ping @anshulpundir @dperny PTAL |
@thaJeztah why are we pulling in all the changes in 18.09 bump ? Shouldnt we target the patches based on severity given 18.09 is in Beta phase ? |
@mavenugo let me defer that to @anshulpundir @dperny there's no 18.09 branch yet for swarmkit, looking at the changes;
|
#89 (comment) looks good. I agree with @thaJeztah cc @dperny |
andrewhsu
approved these changes
Oct 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andrewhsu
changed the title
[18.09 backport] Bump swarmkit to a84c01f49091167dd086c26b45dc18b38d52e4d9
[18.09 backport] Bump swarmkit to a84c01f
Oct 19, 2018
andrewhsu
changed the title
[18.09 backport] Bump swarmkit to a84c01f
WIP [18.09 backport] Bump swarmkit to a84c01f
Oct 19, 2018
was told by @anshulpundir that moby/swarmkit#2768 is in works that could reduce the changeset to pull into the engine 18.09 codeline |
Closing in favor of #94 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
18.09 backports of:
conflict in vendor.conf in first commit, due to #60, which is not upstream