This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] Adding OS version info to the nodes' Info struct
#271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed so that we can add OS version constraints in Swarmkit, which does require the engine to report its host's OS version (see moby/swarmkit#2770). The OS version is parsed from the `os-release` file on Linux, and from the `ReleaseId` string value of the `SOFTWARE\Microsoft\Windows NT\CurrentVersion` registry key on Windows. Added unit tests when possible, as well as Prometheus metrics. Signed-off-by: Jean Rouge <[email protected]> (cherry picked from commit d363a18) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
Info structInfo struct
|
ping @wk8 @andrewhsu @cpuguy83 |
cpuguy83
approved these changes
Jun 7, 2019
|
I talked with @thaJeztah about this and I've expressed hesitation to bring this into the docker-ce 19.03 codeline after we've entered RC phase of the release process because this changes the daemon API and for all of the integration testing we do through the API although this is a small change, we're trying to limit the changes to just bug fixes that are only necessary to bring the codebase to GA. I'd propose we don't take this PR for the 19.03 codeline. |
|
closing this one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of moby#38349 for 19.03
This is needed so that we can add OS version constraints in Swarmkit, which
does require the engine to report its host's OS version (see
moby/swarmkit#2770).
The OS version is parsed from the
os-releasefile on Linux, and from theReleaseIdstring value of theSOFTWARE\Microsoft\Windows NT\CurrentVersionregistry key on Windows.
Added unit tests when possible, as well as Prometheus metrics.