This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[cherry-pick] Enable client side digest pinning for stack deploy #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Totla <[email protected]> (cherry picked from commit 9f1bea2657e1830313ebe4d82e0037bc660a7f73) Signed-off-by: Nishant Totla <[email protected]>
Signed-off-by: Nishant Totla <[email protected]> (cherry picked from commit f790e839fc7d669acafa6365ca7a83cbedfe9e2d) Signed-off-by: Nishant Totla <[email protected]>
nishanttotla
changed the title
Because of cherry-pick from commit f790e839fc7d669acafa6365ca7a83cbedfe9e2d Signed-off-by: Nishant Totla <[email protected]>
nishanttotla
changed the title
This was referenced Jun 8, 2017
|
@dnephin PTAL - I want to make sure the cherry-pick was done correctly since it had to circumvent the refactoring. |
|
LGTM |
docker-jenkins
pushed a commit
that referenced
this pull request
Sep 5, 2018
[18.09] Fix supervisor healthcheck throttling Upstream-commit: 7485ef7e46e2766a0da06fc63001e84d8ea36514 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 29, 2020
[cherry-pick] Enable client side digest pinning for stack deploy
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
[cherry-pick] Enable client side digest pinning for stack deploy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the two commits from docker/cli#121. It is required to avoid a digest-pinning regression for
docker stack deploy.It enables digest pinning for
docker stack deploy, and adds a--resolve-imageflag tostack deployto provide options to control it.Some of the refactoring from docker/cli#145 that came earlier doesn't show up in this cherry-pick, but I've tried to make sure the changes here don't cause problems, since docker/cli#121 is based on top of docker/cli#145 (cc @dnephin)
Tests might fail right now, I'll add a commit to fix them. In particular, changes from moby/moby#33386 are what will be needed.
cc @andrewhsu