This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Multiplex flavor plugins by type in a single RPC endpoint. #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 14, 2017 19:04
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
|
Please sign your commits following these rules: $ git clone -b "multiplex-flavor" [email protected]:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354446536
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Current coverage is 64.82% (diff: 50.76%)@@ master #364 diff @@
==========================================
Files 45 47 +2
Lines 2190 2266 +76
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1432 1469 +37
- Misses 611 637 +26
- Partials 147 160 +13
|
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Sep 30, 2017
make ssh keypair parameter required
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #360 this PR adds support for sub-types in a flavor plugin.
plugin.Name := $lookup[/$type]where $type is defined by the name a flavor SPI implementation is bound in the function to export the object in the RPC server (thePluginServerWithTypesmethod.flavor.Pluginimplementations: one as manager and one as worker -- so the Plugin names should beflavor-swarm/managerandflavor-swarm/worker.Typeswitch in its own Spec schema. Instead, the switch is handled at the RPC layer.scripts/e2e-swarm.shand updated thescripts/e2e-test-plugins.jsontemplate to describe how to start up the vagrant and swarm flavor plugins.