Add `quietPull` option to `up` #1390

ulyssessouza · 2021-03-04T05:48:42Z

What I did
Add quietPull option to up

local/compose/build.go

gtardif

Just add more explicit param to service.build rather than mixing behaviour between tty display and quiet pull option, otherwise LGTM

gtardif · 2021-03-08T09:03:20Z

This is waiting on docker/buildx#558

Signed-off-by: Ulysses Souza <[email protected]>

ulyssessouza requested review from gtardif and ndeloof March 4, 2021 05:48

github-actions bot added api api cli cli local Local context (moby) labels Mar 4, 2021

ulyssessouza commented Mar 4, 2021

View reviewed changes

local/compose/build.go Outdated Show resolved Hide resolved

ulyssessouza marked this pull request as ready for review March 4, 2021 05:52

gtardif reviewed Mar 4, 2021

View reviewed changes

local/compose/build.go Show resolved Hide resolved

gtardif suggested changes Mar 4, 2021

View reviewed changes

ulyssessouza force-pushed the quiet-pull branch from 8d73312 to 5b60ff8 Compare March 5, 2021 01:42

ulyssessouza marked this pull request as draft March 5, 2021 01:42

ulyssessouza mentioned this pull request Mar 5, 2021

Add quiet mode to progress printer docker/buildx#558

Merged

ulyssessouza force-pushed the quiet-pull branch 2 times, most recently from 57092f5 to d14c59c Compare March 5, 2021 03:19

Add quietPull option to up

aa4d15d

Signed-off-by: Ulysses Souza <[email protected]>

ulyssessouza force-pushed the quiet-pull branch from d14c59c to aa4d15d Compare March 10, 2021 14:44

ulyssessouza requested a review from gtardif March 10, 2021 14:46

ulyssessouza marked this pull request as ready for review March 10, 2021 14:46

gtardif approved these changes Mar 11, 2021

View reviewed changes

gtardif merged commit 9301c29 into docker-archive:main Mar 11, 2021

Provide feedback