Integration tests: Initial framework #448
Conversation
Signed-off-by: Andrea Luzzardi <[email protected]>
Signed-off-by: Andrea Luzzardi <[email protected]>
Signed-off-by: Andrea Luzzardi <[email protected]>
It makes integration tests run really slow. Signed-off-by: Andrea Luzzardi <[email protected]>
|
This is fantastic! @aluzzardi is it possible to have a Markdown describing Swarm's testing plan? Like what you did for the roadmap. |
|
@chanwit Yes! I'll be working some more on the framework so it will be possible to write more advanced tests (resources, scheduler policy, constraints, ...) and then I'll put a testing plan somewhere (hopefully sometime next week). I'm planning to use these for regression tests as well. Right now, the version of docker in declared in DOCKER_VERSION (only 1.5 is available atm). Eventually, I'd like to have all versions of docker available in the registry and run the integration tests against all the supported ones (starting at 1.4 and onwards) and perhaps even include master (so we are sure that swarm works all the time with the latest docker before it's even released). Hopefully I can get this running on docker's jenkins to run nightly. @jfrazelle? |
|
@aluzzardi this is great! |
|
👍 |
|
|
||
| # Run the swarm binary. | ||
| function swarm() { | ||
| ${SWARM_ROOT}/swarm $@ |
There was a problem hiding this comment.
Is the bare wordsplitting intended, or should $@ be in double quotes?
Signed-off-by: Andrea Luzzardi <[email protected]>
Signed-off-by: Andrea Luzzardi <[email protected]>
Signed-off-by: Andrea Luzzardi <[email protected]>
|
Thanks @kojiromike, I've made the changes. PTAL |
| for ((i=current; i < instances; i++)); do | ||
| local port=$(($BASE_PORT + $i)) | ||
| HOSTS[$i]=127.0.0.1:$port | ||
| DOCKER_CONTAINERS[$i]=$(docker run -d --name node-$i -h node-$i --privileged -p 127.0.0.1:$port:$port -it ${DOCKER_IMAGE}:${DOCKER_VERSION} docker -d -H 0.0.0.0:$port $args) |
There was a problem hiding this comment.
Sorry I didn't catch this the first time around. Why $args instead of just "$@" at the end of the docker command? Right now you lose the splitting of arguments passed to start_docker.
There was a problem hiding this comment.
It was just to make it obvious that args don't container the first one (since it's right after shift).
It doesn't really though, I can use "$@" instead
Signed-off-by: Andrea Luzzardi <[email protected]>
Signed-off-by: Andrea Luzzardi <[email protected]>
|
@kojiromike PTAL |
Signed-off-by: Andrea Luzzardi <[email protected]>
|
LGTM @kojiromike please open another PR if you can to fix stuff. |
Integration tests: Initial framework
|
Happy to, but I think it's all good now. :) |
This is a continuation of the integration tests, related to #376