Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doccano 1.7 compatibility update #99

Merged
merged 72 commits into from
Oct 6, 2022
Merged

Conversation

lance132
Copy link
Contributor

Adds missing tests for span, span-type, relation, relation-type
Adds category and category-type controllers for Document Classification projects plus corresponding tests
Adds text controller for Seq2seq projects plus corresponding tests
Updates api endpoints for labels and comments
Fixes bug with project attributes

@houssam7737
Copy link
Contributor

Overall looks very solid with a great test suite. A couple minor suggestions to improve documentation and I think this should be ready to merge! Thanks for your contribution! (with your update the client should now be fully operational with Doccano 1.7)

@lance132
Copy link
Contributor Author

lance132 commented Oct 5, 2022

Addressed the comments!

Copy link
Contributor

@houssam7737 houssam7737 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! Thanks

@houssam7737 houssam7737 merged commit 42244f4 into doccano:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants