Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MemberController #139

Merged
merged 9 commits into from
Jan 10, 2023
Merged

Add MemberController #139

merged 9 commits into from
Jan 10, 2023

Conversation

lance132
Copy link
Contributor

@lance132 lance132 commented Dec 29, 2022

Description

Adds model and controller for Member on Doccano projects as well as appropriate tests. This allows for users to be assigned to projects via the client since having to assign users by hand via the UI is a pain point.

Fixes # (issue)

@lance132 lance132 marked this pull request as ready for review December 29, 2022 22:37
Copy link
Contributor

@houssam7737 houssam7737 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward, clean and inline with the style adopted with other controllers in the codebase. Thanks! Can you clarify which issue this solves in the PR description? I think that number is missing. Thank you

@Hironsan Hironsan merged commit 738e865 into doccano:master Jan 10, 2023
@Hironsan
Copy link
Member

Thanks!

lance132 added a commit to lance132/doccano-client that referenced this pull request Feb 8, 2023
Forgot to bump the version when making the MemberController PR here: doccano#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants