Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing attributes to the Zone API responses #47

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Conversation

AGS4NO
Copy link
Contributor

@AGS4NO AGS4NO commented Dec 12, 2023

This PR adds missing attributes of the Zone response:

  • secondary, last_transferred_at, active to Zone struct

Belongs to https://github.com/dnsimple/dnsimple-external-integrations/issues/17

@AGS4NO AGS4NO self-assigned this Dec 12, 2023
@AGS4NO
Copy link
Contributor Author

AGS4NO commented Dec 12, 2023

cc @DXTimer

package `colored v2.1.0` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.65.0

Dependency colored is no longer supported on this version of Rust. We can either pin the colored dep back to an older version or bump our rust version. We have a note that the rust version is pinned due to support for deps that use let-else but tests are passing on 1.74.1 in my local and that version also supports the latest colored dep.

I am leaning towards pushing the rust version updates, any other concerns with bumping this up?

@DXTimer DXTimer added the enhancement New feature, enhancement or code changes, not related to defects label Dec 13, 2023
@DXTimer
Copy link
Contributor

DXTimer commented Dec 13, 2023

Thanks for flagging this up @AGS4NO. I have pinned the version for the moment as I am working on updating our CI to build against the stable and nightly versions. I am hesitant when it comes to increasing the MSRV due to dev dependencies only. Let's deal with this in a separate PR.

@AGS4NO AGS4NO marked this pull request as ready for review December 13, 2023 16:03
@AGS4NO AGS4NO requested a review from a team December 13, 2023 16:03
@AGS4NO AGS4NO merged commit 20c7339 into main Dec 13, 2023
4 checks passed
@AGS4NO AGS4NO deleted the enhancement/zones-api branch December 13, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, enhancement or code changes, not related to defects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants