Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DomainTransferLockEnable and DomainTransferLockDisable event types #149

Merged
9 commits merged into from
Sep 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2023

Add the struct types for the domain.transfer_lock_enable and domain.transfer_lock_disable events.

Belongs to https://github.com/dnsimple/dnsimple-business/issues/1728

@ghost ghost added the enhancement New feature, enhancement or code changes, not related to defects label Sep 1, 2023
@ghost ghost self-requested a review September 1, 2023 05:21
@ghost ghost self-assigned this Sep 1, 2023
dnsimple/webhook/events.go Show resolved Hide resolved
dnsimple/webhook/events.go Outdated Show resolved Hide resolved
@ghost ghost requested a review from DXTimer September 1, 2023 06:14
Copy link
Contributor

@DXTimer DXTimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add tests for the new events in events_test.go.

@weppos
Copy link
Member

weppos commented Sep 6, 2023

Add the struct types for the domain.lock and domain.unlock events.

These event names are too generic. Please see my notes at dnsimple/dnsimple-developer#519 (comment)

@ghost ghost requested a review from DXTimer September 6, 2023 14:07
@ghost ghost changed the title Add DomainLock and DomainUnlock event types Add DomainTransferLockEnable and DomainTransferLockDisable event types Sep 12, 2023
@ghost ghost merged commit 1ea14a2 into main Sep 12, 2023
@ghost ghost deleted the feature/domain-lock-events branch September 12, 2023 04:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, enhancement or code changes, not related to defects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants